Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testdriver to return results to tests. #18431

Merged

Conversation

@LukeZielinski
Copy link
Contributor

LukeZielinski commented Aug 14, 2019

This resolves issue #10716, and is recreated from an earlier PR #11080.

The immediate use case for this is to support testing of WebAuthN, specifically a getCredentials function that can be used to inspect keys installed on a device. More info on this in the testing API doc and proposed spec change.

@LukeZielinski
Copy link
Contributor Author

LukeZielinski commented Aug 14, 2019

@gsnedders since you were involved in #11080

I think the only remaining AI from that old PR is the question about testing. Longer term when the getCredentials API exists we can have an infra test for that which should cover this feature.

Right now, I just hacked an existing API to return stuff and it behaves as expected locally: #18432

@wpt-pr-bot wpt-pr-bot added the docs label Aug 14, 2019
@wpt-pr-bot wpt-pr-bot requested a review from sideshowbarker Aug 14, 2019
@LukeZielinski
Copy link
Contributor Author

LukeZielinski commented Aug 15, 2019

@nsatragno FYI1

@LukeZielinski LukeZielinski merged commit 5fc1b5c into web-platform-tests:master Aug 19, 2019
18 checks passed
18 checks passed
update-pr-preview
Details
update-pr-preview
Details
update-pr-preview
Details
Azure Pipelines Build #20190814.142 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (tools/ unittests: Windows Python 3) tools/ unittests: Windows Python 3 succeeded
Details
Azure Pipelines (tools/ unittests: Windows) tools/ unittests: Windows succeeded
Details
Azure Pipelines (tools/ unittests: macOS) tools/ unittests: macOS succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows) tools/wpt/ tests: Windows succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS) tools/wpt/ tests: macOS succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows) tools/wptrunner/ unittests: Windows succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS) tools/wptrunner/ unittests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
@LukeZielinski LukeZielinski deleted the LukeZielinski:testdriver-returns branch Aug 19, 2019
natechapin added a commit to natechapin/wpt that referenced this pull request Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.