Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pointerevents] Serialization of touch-action #18439

Merged

Conversation

@ewilligers
Copy link
Contributor

ewilligers commented Aug 14, 2019

Tests that the CSS property touch-action supports each
value specified in the spec, and serializes correctly.

Tests that touch-action has initial value auto, and does
not inherit.

https://w3c.github.io/pointerevents/#the-touch-action-css-property

Tests that the CSS property touch-action supports each
value specified in the spec, and serializes correctly.

Tests that touch-action has initial value auto, and does
not inherit.

https://w3c.github.io/pointerevents/#the-touch-action-css-property
@ewilligers
Copy link
Contributor Author

ewilligers commented Aug 14, 2019

@emilio The spec mentions "Additional touch-action values common in implementations are defined in [COMPAT]."

I skipped those values as they are not required by the spec.

@emilio
emilio approved these changes Aug 15, 2019
Copy link
Contributor

emilio left a comment

I think if they're required for compat they should be moved to the pointer events spec... But anyhow this is ok until that happens, thanks!

It seems CI is red but it looks like infra.

@ewilligers ewilligers merged commit 85837ef into web-platform-tests:master Aug 15, 2019
9 of 10 checks passed
9 of 10 checks passed
update-pr-preview
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190814.197 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - firefox[experimental] Firefox results
Details
@ewilligers ewilligers deleted the ewilligers:touch-action-serialization branch Aug 15, 2019
@NavidZ
Copy link
Contributor

NavidZ commented Aug 15, 2019

@emilio I don't think that can happen anytime soon because of the IP stuff. But implementors have implemented pinch-zoom and we thought lets at least document it somewhere and that was in compat whatwg spec. Regardless not having the test for that special value under the PE test folder looks fine.

@ewilligers thanks for adding the tests. Quick question. Any reason you put some of these tests under the parsing folder? Is this the pattern across other specs as well? In PE directory we have been using folders for tests that were testing interaction of PE with other specs. If there is no particular reason I might just move the tests under parsing directly in the main folder later.

@ewilligers
Copy link
Contributor Author

ewilligers commented Aug 15, 2019

Any reason you put some of these tests under the parsing folder? Is this the pattern across other specs as well?

I have been using this pattern for all the CSS property parsing/serialization tests. touch-action is to date the only property I have tested outside the css/ and svg/ directories. The tests can certainly be moved for consistency with existing pointerevents/ structure.

./css/compositing/parsing 9
./css/css-align/parsing 36
./css/css-animations/parsing 24
./css/css-backgrounds/parsing 66
./css/css-box/parsing 28
./css/css-break/parsing 18
./css/css-cascade/parsing 2
./css/css-color-adjust/parsing 3
./css/css-color/parsing 6
./css/css-contain/parsing 3
./css/css-display/parsing 3
./css/css-flexbox/parsing 24
./css/css-fonts/parsing 47
./css/css-forced-color-adjust/parsing 3
./css/css-grid/parsing 15
./css/css-images/parsing 16
./css/css-inline/parsing 9
./css/css-lists/parsing 18
./css/css-logical/parsing 48
./css/css-masking/parsing 14
./css/css-multicol/parsing 26
./css/cssom-view/parsing 3
./css/css-overflow/parsing 16
./css/css-overscroll-behavior/parsing 3
./css/css-position/parsing 30
./css/css-rhythm/parsing 3
./css/css-ruby/parsing 4
./css/css-scroll-anchoring/parsing 3
./css/css-scroll-snap/parsing 27
./css/css-shapes/parsing 11
./css/css-size-adjust/parsing 3
./css/css-sizing/parsing 15
./css/css-tables/parsing 15
./css/css-text-decor/parsing 21
./css/css-text/parsing 45
./css/css-transforms/parsing 20
./css/css-transitions/parsing 12
./css/css-ui/parsing 34
./css/css-will-change/parsing 3
./css/css-writing-modes/parsing 15
./css/filter-effects/parsing 18
./css/motion/parsing 13
./pointerevents/parsing 3
./svg/geometry/parsing 24
./svg/interact/parsing 3
./svg/painting/parsing 60
./svg/pservers/parsing 4
./svg/text/parsing 14
natechapin added a commit to natechapin/wpt that referenced this pull request Aug 23, 2019
Tests that the CSS property touch-action supports each
value specified in the spec, and serializes correctly.

Tests that touch-action has initial value auto, and does
not inherit.

https://w3c.github.io/pointerevents/#the-touch-action-css-property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.