Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge CSS comparison functions min/max with CSS typed OM objects #18446

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 15, 2019

This patch adds two-way conversions between CSS typed OM objects and
Blink internal CSSMathFunction objects when comparison functions are
involved, so that we can operate on CSS comparison functions with
typed OM effectively.

Bug: 825895
Change-Id: I883f5691ad6ac564b575f62be4b96a169743715d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745621
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687418}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

This patch adds two-way conversions between CSS typed OM objects and
Blink internal CSSMathFunction objects when comparison functions are
involved, so that we can operate on CSS comparison functions with
typed OM effectively.

Bug: 825895
Change-Id: I883f5691ad6ac564b575f62be4b96a169743715d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745621
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687418}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1745621 branch from a041b60 to a541f30 Aug 15, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 5cf74f9 into master Aug 15, 2019
14 of 15 checks passed
14 of 15 checks passed
update-pr-preview
Details
Build Failed Build Failed
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190815.211 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1745621 branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.