Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webnfc] Replace NDEFRecordData#data() with multiple getters #18449

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 15, 2019

The spec change was introduced at
w3c/web-nfc#243.

BUG=520391
TBR=dcheng
for just adding a TODO into
third_party/blink/renderer/modules/nfc/nfc_type_converters.h

Change-Id: Iee1841352417065cdf13b08a82ac79cfd6cdb7a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755642
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#688007}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1755642 branch 2 times, most recently from f260bd8 to 5eaf9cc Aug 15, 2019
The spec change was introduced at
w3c/web-nfc#243.

BUG=520391
TBR=dcheng
for just adding a TODO into
third_party/blink/renderer/modules/nfc/nfc_type_converters.h

Change-Id: Iee1841352417065cdf13b08a82ac79cfd6cdb7a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755642
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#688007}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1755642 branch from 5eaf9cc to 2b79496 Aug 19, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 790b990 into master Aug 19, 2019
14 checks passed
14 checks passed
update-pr-preview
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
Azure Pipelines Build #20190819.21 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1755642 branch Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.