Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1573907] Fix interaction of <li value> inside <ol reversed>. #18451

Merged
merged 2 commits into from Aug 15, 2019

Conversation

@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Aug 15, 2019

The counting code was incrementing the start counter twice for

  • , as it
    generates both an increment and a reset.

    We should instead only increment it once per list-item, that is, once per
    increment.

    Differential Revision: https://phabricator.services.mozilla.com/D42001

    bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1573907
    gecko-commit: a9bdb526a7a01e0984c2bf8c888e8d8ffc69c5c4
    gecko-integration-branch: autoland
    gecko-reviewers: mats

  • The counting code was incrementing the start counter twice for <li value>, as it
    generates both an increment and a reset.
    
    We should instead only increment it once per list-item, that is, once per
    increment.
    
    Differential Revision: https://phabricator.services.mozilla.com/D42001
    
    bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1573907
    gecko-commit: a9bdb526a7a01e0984c2bf8c888e8d8ffc69c5c4
    gecko-integration-branch: autoland
    gecko-reviewers: mats
    Copy link
    Collaborator

    wpt-pr-bot left a comment

    Already reviewed downstream.

    Differential Revision: https://phabricator.services.mozilla.com/D42084
    
    bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1573907
    gecko-commit: 0bc9d6bfeb5a08b9dfe2f03c897e564478982e36
    gecko-integration-branch: autoland
    gecko-reviewers: mats
    @moz-wptsync-bot moz-wptsync-bot merged commit 1b240aa into master Aug 15, 2019
    13 of 14 checks passed
    13 of 14 checks passed
    website-build-and-publish
    Details
    manifest-build-and-tag
    Details
    update-pr-preview
    Details
    upstream/gecko Landed on mozilla-central
    Details
    wpt.fyi - chrome[experimental] Chrome results
    Details
    wpt.fyi - firefox[experimental] Firefox results
    Details
    wpt.fyi - safari[experimental] Safari results
    Details
    Azure Pipelines Build #20190815.83 succeeded
    Details
    Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
    Details
    Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
    Details
    Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
    Details
    Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
    Details
    Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
    Details
    Taskcluster (pull_request) TaskGroup: success
    Details
    @moz-wptsync-bot moz-wptsync-bot deleted the gecko/1573907 branch Aug 15, 2019
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Linked issues

    Successfully merging this pull request may close these issues.

    None yet

    3 participants
    You can’t perform that action at this time.