Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Pipelines] drop old workaround for `safaridriver --version` #18454

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@foolip
Copy link
Member

foolip commented Aug 15, 2019

The --version argument is supported starting in Safari 12.1:
web-platform-tests/results-collection#617

The `--version` argument is supported starting in Safari 12.1:
web-platform-tests/results-collection#617
@wpt-pr-bot wpt-pr-bot added the infra label Aug 15, 2019
@wpt-pr-bot wpt-pr-bot requested a review from jgraham Aug 15, 2019
@foolip foolip requested a review from gsnedders Aug 15, 2019
@foolip
Copy link
Member Author

foolip commented Aug 15, 2019

I've started https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=27261 to test this, to see if what shows up in wpt.fyi has the right version as hoped.

@foolip
Copy link
Member Author

foolip commented Aug 15, 2019

https://wpt.fyi/results/?run_id=286580001 is the run that resulted from this, showing that it works :)

@Ms2ger
Ms2ger approved these changes Aug 21, 2019
@foolip foolip merged commit a2d1acf into master Aug 21, 2019
17 checks passed
17 checks passed
website-build-and-publish
Details
manifest-build-and-tag
Details
update-pr-preview
Details
Azure Pipelines Build #20190815.89 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (all tests: Safari 1) all tests: Safari 1 succeeded
Details
Azure Pipelines (all tests: Safari 2) all tests: Safari 2 succeeded
Details
Azure Pipelines (all tests: Safari 3) all tests: Safari 3 succeeded
Details
Azure Pipelines (all tests: Safari 4) all tests: Safari 4 succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-results) wpt.fyi hook: safari-results succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - safari[experimental] Safari results
Details
@foolip foolip deleted the foolip/azure-safaridriver-version branch Aug 21, 2019
natechapin added a commit to natechapin/wpt that referenced this pull request Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.