Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up WPT TestExpectations for CSS animations and transitions #18458

Merged
merged 1 commit into from Aug 17, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 15, 2019

external/wpt/css/css-animations/Element-getAnimations.tentative.html
external/wpt/css/css-transitions/AnimationEffect-getComputedTiming.tentative.html
(turned on and baselined, code appears to have been fixed earlier)

external/wpt/css/css-transitions/CSSTransition-startTime.tentative.html
(now has same behavior reargless of when in frame the test is started)

external/wpt/css/css-transitions/properties-value-*
(fix duration to allow for CPU stress and add RAF before checking event
handlers are called, using guideline in
https://web-platform-tests.org/writing-tests/testharness-api.html#timeouts-in-tests
"Note that timeouts generally need to be a few seconds long
in order to produce stable results in all test environments.")

external/wpt/css/css-transitions/no-transition-from-ua-to-blocking-stylesheet.html
(marked flaky instead of always-fail, test sometimes passes)

REMOVE external/wpt/css/css-transitions/transitions-animatable-properties-01.html
(old and flaky duplicate of properties-value-001.html)
(serial timeouts add to close to 60s, causing harness timeout in CI)

Bug: 849975, 849927, 922970, 825262, 332189, 626703,
Change-Id: Id03994b3017ac72858dca00ee71d9b89dacbd3c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748116
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Auto-Submit: George Steel <gtsteel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687422}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1748116 branch from 6d68f51 to f0ca751 Aug 15, 2019
external/wpt/css/css-animations/Element-getAnimations.tentative.html
external/wpt/css/css-transitions/AnimationEffect-getComputedTiming.tentative.html
(turned on and baselined, code appears to have been fixed earlier)

external/wpt/css/css-transitions/CSSTransition-startTime.tentative.html
(now has same behavior reargless of when in frame the test is started)

external/wpt/css/css-transitions/properties-value-*
(fix duration to allow for CPU stress and add RAF before checking event
handlers are called, using guideline in
https://web-platform-tests.org/writing-tests/testharness-api.html#timeouts-in-tests
"Note that timeouts generally need to be a few seconds long
in order to produce stable results in all test environments.")

external/wpt/css/css-transitions/no-transition-from-ua-to-blocking-stylesheet.html
(marked flaky instead of always-fail, test sometimes passes)

REMOVE external/wpt/css/css-transitions/transitions-animatable-properties-01.html
(old and flaky duplicate of properties-value-001.html)
(serial timeouts add to close to 60s, causing harness timeout in CI)

Bug: 849975, 849927, 922970, 825262, 332189, 626703,
Change-Id: Id03994b3017ac72858dca00ee71d9b89dacbd3c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748116
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Auto-Submit: George Steel <gtsteel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687422}
@Hexcles
Copy link
Member

Hexcles commented Aug 17, 2019

The flakiness is pre-existing.

@Hexcles Hexcles merged commit b0545c7 into master Aug 17, 2019
16 of 19 checks passed
16 of 19 checks passed
website-build-and-publish
Details
manifest-build-and-tag
Details
update-pr-preview
Details
update-pr-preview
Details
Build Failed Build Failed
Details
Build Failed Build Failed
Details
Taskcluster (pull_request) TaskGroup: failure
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190816.166 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
@Hexcles Hexcles deleted the chromium-export-cl-1748116 branch Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.