Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix :enabled so that it does not match links #18460

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 15, 2019

The spec [1] is clear that :enabled and :disabled should not match
link elements. Prior to this CL, links would match :enabled in Chrome,
but would never match :disabled. This is obviously contrary to the
spec, and it also does not match other browsers' behavior:
Firefox (68), Safari (12.1), Edge (18) and IE (11) all work according
to the spec.

Now, neither :enabled nor :disabled match links in Chrome.

[1] https://html.spec.whatwg.org/multipage/semantics-other.html#selector-enabled

Bug: 993387
Change-Id: I745a314fdac720243ebf37eed4fdcf57228cc3cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754509
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688241}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1754509 branch from cf3871a to 32d4a48 Aug 16, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Make :enabled not match links Fix :enabled so that it does not match links Aug 19, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1754509 branch from 32d4a48 to 3b2d5e2 Aug 19, 2019
The spec [1] is clear that :enabled and :disabled should *not* match
link elements. Prior to this CL, links would match :enabled in Chrome,
but would never match :disabled. This is obviously contrary to the
spec, and it also does not match other browsers' behavior:
Firefox (68), Safari (12.1), Edge (18) and IE (11) all work according
to the spec.

Now, neither :enabled nor :disabled match links in Chrome.

[1] https://html.spec.whatwg.org/multipage/semantics-other.html#selector-enabled

Bug: 993387
Change-Id: I745a314fdac720243ebf37eed4fdcf57228cc3cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754509
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688241}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1754509 branch from 3b2d5e2 to a856e08 Aug 19, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 6bd88d3 into master Aug 19, 2019
14 checks passed
14 checks passed
update-pr-preview
Details
wpt.fyi - chrome[experimental] Chrome results
Details
Azure Pipelines Build #20190819.171 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1754509 branch Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.