Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[LayoutNG] Set table-cell borders, and intrinsic-padding via. constraints. #18463
Conversation
|
Already reviewed downstream. |
chromium-wpt-export-bot
force-pushed the
chromium-export-cl-1754097
branch
3 times, most recently
from
1f91210
to
3dae6ca
…ints. As above, this was some previously accumulated debt. It isn't clear if the intrinsic-padding is a good concept yet, but removes some bad layout-box calls. Bug: 993095 Change-Id: Idc4e9e67afa2fbd9c84976cb2878b215624298c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754097 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#687511}
chromium-wpt-export-bot
force-pushed the
chromium-export-cl-1754097
branch
from
3dae6ca
to
6483c3a
chromium-wpt-export-bot
merged commit 6a70fc3
into
master
11 checks passed
11 checks passed
Azure Pipelines (affected tests without changes: Safari Technology Preview)
affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview)
affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes)
wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
chromium-wpt-export-bot commentedAug 15, 2019
•
edited
As above, this was some previously accumulated debt. It isn't clear if
the intrinsic-padding is a good concept yet, but removes some bad
layout-box calls.
Bug: 993095
Change-Id: Idc4e9e67afa2fbd9c84976cb2878b215624298c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754097
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687511}