Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Set table-cell borders, and intrinsic-padding via. constraints. #18463

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 15, 2019

As above, this was some previously accumulated debt. It isn't clear if
the intrinsic-padding is a good concept yet, but removes some bad
layout-box calls.

Bug: 993095
Change-Id: Idc4e9e67afa2fbd9c84976cb2878b215624298c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754097
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687511}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1754097 branch 3 times, most recently from 1f91210 to 3dae6ca Aug 15, 2019
…ints.

As above, this was some previously accumulated debt. It isn't clear if
the intrinsic-padding is a good concept yet, but removes some bad
layout-box calls.

Bug: 993095
Change-Id: Idc4e9e67afa2fbd9c84976cb2878b215624298c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754097
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687511}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1754097 branch from 3dae6ca to 6483c3a Aug 16, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 6a70fc3 into master Aug 16, 2019
11 checks passed
11 checks passed
update-pr-preview
Details
Azure Pipelines Build #20190816.17 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1754097 branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.