Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check requested reference space against enabled XR session features #18471

Merged
merged 1 commit into from Aug 17, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 15, 2019

Currently we only check if the requested reference space is supported
by the device before resolving the request. With more detailed consent
this is no longer sufficient, we need to also check the underlying
feature of the reference space against which features have been enabled.

This CL also does some minor refactoring of code related to
XRSessionFeature.

Bug: 985095
Change-Id: Ibe6ecadbc6ce25c523eb4ee9d8a73560d8580df5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754275
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Will Cassella <cassew@google.com>
Cr-Commit-Position: refs/heads/master@{#687912}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

Currently we only check if the requested reference space is supported
by the device before resolving the request. With more detailed consent
this is no longer sufficient, we need to also check the underlying
feature of the reference space against which features have been enabled.

This CL also does some minor refactoring of code related to
XRSessionFeature.

Bug: 985095
Change-Id: Ibe6ecadbc6ce25c523eb4ee9d8a73560d8580df5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754275
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Will Cassella <cassew@google.com>
Cr-Commit-Position: refs/heads/master@{#687912}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1754275 branch from 1d1dab5 to c78e545 Aug 17, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit ffc0fba into master Aug 17, 2019
14 checks passed
14 checks passed
update-pr-preview
Details
Azure Pipelines Build #20190817.9 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1754275 branch Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.