Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LargestContentfulPaint] Add larger content tests #18472

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 15, 2019

This CL adds tests where there is a bunch of content and LCP must observe the
largest (one for when image is largest, one for text).

Bug: 994414
Change-Id: I9330f238e1f8a2a8227dce7a04fd741d2dc666d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757165
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688087}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

This CL adds tests where there is a bunch of content and LCP must observe the
largest (one for when image is largest, one for text).

Bug: 994414
Change-Id: I9330f238e1f8a2a8227dce7a04fd741d2dc666d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757165
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688087}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1757165 branch from 57b7bd4 to 5bf819d Aug 19, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 93e7ae0 into master Aug 19, 2019
13 of 15 checks passed
13 of 15 checks passed
update-pr-preview
Details
Build Failed Build Failed
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190819.113 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1757165 branch Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.