Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mojo] Add testing support to BrowserInterfaceBrokerProxy #18475

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 16, 2019

This change adds a SetBinderForTesting() method to
BrowserInterfaceBrokerProxy and modifies MojoInterfaceInterceptor to
call this new method if a script passes a new "useBrowserInterfaceBroker"
parameter.
Also converts IdleManager to use BrowserInterfaceBrokerProxy as a use
case for overriding interface handlers in web tests.

Bug: 985118
Change-Id: I8dc3fc1c4beb2ae375a2534b03cd890ce1e3b52c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756480
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688743}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

This change adds a SetBinderForTesting() method to
BrowserInterfaceBrokerProxy and modifies MojoInterfaceInterceptor to
call this new method if a script passes a new "useBrowserInterfaceBroker"
parameter.
Also converts IdleManager to use BrowserInterfaceBrokerProxy as a use
case for overriding interface handlers in web tests.

Bug: 985118
Change-Id: I8dc3fc1c4beb2ae375a2534b03cd890ce1e3b52c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756480
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688743}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1756480 branch from 780bf9a to 99e5aa2 Aug 20, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 7b7272a into master Aug 20, 2019
14 checks passed
14 checks passed
update-pr-preview
Details
Azure Pipelines Build #20190820.121 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1756480 branch Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.