Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SyntheticModules] Allows for Fetching and Loading of JSON/Synthetic Modules #18477

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 16, 2019

This is the final change required for JSON Modules to be utilized by developers.
Following the acceptance of this change, if you run chromium with the JSONModules runtime flag, the following is now valid syntax:

<script type="module">
import data from "./example.json";
</script>

This change introduces several things:

-It introduces the ability for ModuleScriptLoader to load JSON Modules
-It introduces the ability for ModuleScriptFetcher to retrieve JSON resources
-It introduces a new field to ModuleScriptCreationParams: response_mime_type_
-It introduces the JSONModules runtime flag to chromium

This change corresponds with the following V8 change:
https://chromium-review.googlesource.com/c/v8/v8/+/1761583

Bug: 967018
Change-Id: Ibcdb61659fb07047ffeead2ff4a55c450c183e43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731108
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Sam Sebree <sasebree@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#688905}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1731108 branch 2 times, most recently from 98d3fbc to ce13d7c Aug 16, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1731108 branch 2 times, most recently from 6b64fd0 to a4c7b44 Aug 20, 2019
…Modules

This is the final change required for JSON Modules to be utilized by developers.
Following the acceptance of this change, if you run chromium with the JSONModules runtime flag, the following is now valid syntax:

<script type="module">
    import data from "./example.json";
</script>

This change introduces several things:

-It introduces the ability for ModuleScriptLoader to load JSON Modules
-It introduces the ability for ModuleScriptFetcher to retrieve JSON resources
-It introduces a new field to ModuleScriptCreationParams: response_mime_type_
-It introduces the JSONModules runtime flag to chromium

This change corresponds with the following V8 change:
https://chromium-review.googlesource.com/c/v8/v8/+/1761583

Bug: 967018
Change-Id: Ibcdb61659fb07047ffeead2ff4a55c450c183e43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731108
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Sam Sebree <sasebree@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#688905}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1731108 branch from a4c7b44 to 4ff426b Aug 21, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit a8a1303 into master Aug 21, 2019
14 checks passed
14 checks passed
update-pr-preview
Details
Azure Pipelines Build #20190821.35 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1731108 branch Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.