Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Ahem as web font in vars-font-shorthand-001.html #18485

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@foolip
Copy link
Member

foolip commented Aug 16, 2019

No description provided.

@foolip
Copy link
Member Author

foolip commented Aug 16, 2019

@LukeZielinski this test appears to predate your Ahem rewrite. Can you check why this test was missed and if there are any more like it?

@LukeZielinski
Copy link
Contributor

LukeZielinski commented Aug 19, 2019

Ok, so this test sets a variable to "ahem" and then sets font-family to that variable. Not sure there's any reasonable way to grep for that, and there very well might be more tests like this.

I plan to do a final sweep where I update the WPT code to disable installing ahem completely and then see what breaks on CI. That should catch cases like this.

@foolip
Copy link
Member Author

foolip commented Sep 3, 2019

@LukeZielinski can you also review this change?

@foolip foolip force-pushed the foolip/ahem-vars-font-shorthand branch from 08fec17 to 57319ca Sep 3, 2019
Copy link
Contributor

LukeZielinski left a comment

lgtm

@foolip foolip merged commit 8f45c16 into master Sep 3, 2019
16 checks passed
16 checks passed
website-build-and-publish
Details
manifest-build-and-tag
Details
update-pr-preview
Details
Azure Pipelines Build #20190903.40 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@foolip foolip deleted the foolip/ahem-vars-font-shorthand branch Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.