Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use StyleEngine::InRebuildLayoutTree() to check if we are rebuilding. #18490

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 16, 2019

We used ChildNeedsReattachLayoutTree() on documentElement() to check
after [1], but that is false if it's only the root element which is
marked for re-attachment.

[1] https://crrev.com/df2ed4afdfaf3b30adc3d4d80cc7559965eb8519

Bug: 993764
Change-Id: If4656e1c478ee74d26e6e1a39dcef601837020e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755990
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687607}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

We used ChildNeedsReattachLayoutTree() on documentElement() to check
after [1], but that is false if it's only the root element which is
marked for re-attachment.

[1] https://crrev.com/df2ed4afdfaf3b30adc3d4d80cc7559965eb8519

Bug: 993764
Change-Id: If4656e1c478ee74d26e6e1a39dcef601837020e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755990
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687607}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1755990 branch from e3b92b6 to ed4ee6a Aug 16, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 936827a into master Aug 16, 2019
14 checks passed
14 checks passed
update-pr-preview
Details
Azure Pipelines Build #20190816.92 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1755990 branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.