Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new list for paced animation values #18491

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 16, 2019

SVGAnimationElement::calculateKeyTimesForCalcModePaced() used to
overwrite the data passed in by the user. This commit fixes the
issue and there are now two lists stored, one with the user data
and one with the key times for paced.

This is a bug fix and should only affect SVGAnimationElements,
there will be an increase in memory usage, especially for animation
intensive scenes. Can be avoided by changing to a CPU heavy approach,
but this will probably be more energy efficient for mobile devices.

Bug: 231525
Change-Id: Ief9bbb8c6d1133d0041ad2c8f5a3d63f9ddcde90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757825
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Edvard Thörnros <edvardt@opera.com>
Cr-Commit-Position: refs/heads/master@{#687651}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Create new vector for paced animation values Create new list for paced animation values Aug 16, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1757825 branch 3 times, most recently from 3a52956 to 37aed89 Aug 16, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1757825 branch from 37aed89 to a896ce0 Aug 16, 2019
SVGAnimationElement::calculateKeyTimesForCalcModePaced() used to
overwrite the data passed in by the user. This commit fixes the
issue and there are now two lists stored, one with the user data
and one with the key times for paced.

This is a bug fix and should only affect SVGAnimationElements,
there will be an increase in memory usage, especially for animation
intensive scenes. Can be avoided by changing to a CPU heavy approach,
but this will probably be more energy efficient for mobile devices.

Bug: 231525
Change-Id: Ief9bbb8c6d1133d0041ad2c8f5a3d63f9ddcde90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757825
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Edvard Thörnros <edvardt@opera.com>
Cr-Commit-Position: refs/heads/master@{#687651}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1757825 branch from a896ce0 to 4c0d199 Aug 16, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 6ee2743 into master Aug 16, 2019
13 of 15 checks passed
13 of 15 checks passed
Build Failed Build Failed
Details
Build Failed Build Failed
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190816.134 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1757825 branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.