Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the results jobs when idlharness.js changes #18500

Merged
merged 4 commits into from Sep 26, 2019
Merged

Conversation

@lukebjerring
Copy link
Contributor

lukebjerring commented Aug 16, 2019

Includes #18382 temporarily to fully test the behaviour.

Copy link
Contributor

jgraham left a comment

Subject to removing earlier commit

@ghost
Copy link

ghost commented Aug 16, 2019

Submitting the task to Taskcluster failed. Details

InterpreterError at template.tasks[1].payload.command[3]: object has no property job_name

1 similar comment
@ghost
Copy link

ghost commented Aug 16, 2019

Submitting the task to Taskcluster failed. Details

InterpreterError at template.tasks[1].payload.command[3]: object has no property job_name

@lukebjerring lukebjerring changed the title Run the stability job when idlharness.js changes Run the results jobs when idlharness.js changes Aug 16, 2019
@lukebjerring
Copy link
Contributor Author

lukebjerring commented Aug 16, 2019

@jgraham - I've totally changed this PR, as per discussion, it makes sense to distinguish the single run job from stability for the idlharness.js case.

PTAL

@ghost
Copy link

ghost commented Aug 16, 2019

Submitting the task to Taskcluster failed. Details

InterpreterError at template.tasks[1].payload.command[3]: object has no property job_name

@foolip
foolip approved these changes Sep 2, 2019
Copy link
Member

foolip left a comment

This looks reasonable to me, but I'd like to hear if @jgraham has more feedback. When I was setting up Azure Pipelines I think I suggested introducing an affected_tests job, but ended up making the jobs unconditional instead.

I wonder if we should change Azure Pipelines to use this new job as well, or make unconditional on Taskcluster too? (Need not block this change.)

@gsnedders
Copy link
Contributor

gsnedders commented Sep 4, 2019

Does it really not timeout running the stability job for idlharness.js? Huh.

@lukebjerring
Copy link
Contributor Author

lukebjerring commented Sep 4, 2019

No, you're right, it does time out, which is why this change distinguishes single run from stability for including idlharness.js.

@gsnedders
Copy link
Contributor

gsnedders commented Sep 4, 2019

Gah. I can't read. 🙂

This looks reasonable to me too.

@lukebjerring lukebjerring force-pushed the idlharness-stability branch from d09996b to a1c3788 Sep 26, 2019
@lukebjerring
Copy link
Contributor Author

lukebjerring commented Sep 26, 2019

Taskcluster failure is #19297

@lukebjerring lukebjerring merged commit 120c6c0 into master Sep 26, 2019
17 of 18 checks passed
17 of 18 checks passed
update-pr-preview
Details
Taskcluster (pull_request) TaskGroup: failure
Details
Azure Pipelines Build #20190926.58 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (tools/ unittests: Windows Python 3) tools/ unittests: Windows Python 3 succeeded
Details
Azure Pipelines (tools/ unittests: Windows) tools/ unittests: Windows succeeded
Details
Azure Pipelines (tools/ unittests: macOS) tools/ unittests: macOS succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows) tools/wpt/ tests: Windows succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS) tools/wpt/ tests: macOS succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows) tools/wptrunner/ unittests: Windows succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS) tools/wptrunner/ unittests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - safari[experimental] Safari results
Details
@lukebjerring lukebjerring deleted the idlharness-stability branch Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.