Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword test names generated by interpolation-testcommon.js #18507

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 16, 2019

Previously the generated test names were of the form:

property foo from <value> to <value> at <progress> is <actual-value>

This read weirdly when the test failed:

property foo from 0 to 1 at 0.5 is 'bananas': expected 0.5 but got 'bananas'

This CL re-words the test names to read like:

property foo from 0 to 1 at 0.5 should be 0.5: expected 0.5 but got 'bananas'

Bug: 900581
Change-Id: I77a02a24648171b3945d41cbf81d982879f4500d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758283
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687653}

Previously the generated test names were of the form:

  property foo from <value> to <value> at <progress> is <actual-value>

This read weirdly when the test failed:

  property foo from 0 to 1 at 0.5 is 'bananas': expected 0.5 but got 'bananas'

This CL re-words the test names to read like:

  property foo from 0 to 1 at 0.5 should be 0.5: expected 0.5 but got 'bananas'

Bug: 900581
Change-Id: I77a02a24648171b3945d41cbf81d982879f4500d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758283
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687653}
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@Hexcles
Copy link
Member

Hexcles commented Aug 16, 2019

Error is not caused by this PR and will be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1758486

@Hexcles Hexcles merged commit 81f8d11 into master Aug 16, 2019
13 of 14 checks passed
13 of 14 checks passed
update-pr-preview
Details
Taskcluster (pull_request) TaskGroup: failure
Details
Azure Pipelines Build #20190816.221 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@Hexcles Hexcles deleted the chromium-export-6b061dfcc3 branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.