Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interpolation-testcommon.js on Firefox #18508

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 16, 2019

The new test generation logic had some problems:

i. It produced different sets of tests on different browsers depending
on the support status. This caused difficulties comparing test results
across browsers.

ii. It produced duplicate subtest names when a 'from', 'to', or
'underlying' was not supported. Duplicate subtests are a fatal error
in WPT.

This CL fixes these problems by always generating the tests, and
asserting support in them.

It also removes the composition code, which was unused.

Bug: 900581
Change-Id: Id5617881bbf3b5f0a0b8eade5b630aa8fd65af8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758486
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687797}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

The new test generation logic had some problems:

  i. It produced different sets of tests on different browsers depending
  on the support status. This caused difficulties comparing test results
  across browsers.

  ii. It produced duplicate subtest names when a 'from', 'to', or
  'underlying' was not supported. Duplicate subtests are a fatal error
  in WPT.

This CL fixes these problems by always generating the tests, and
asserting support in them.

It also removes the composition code, which was unused.

Bug: 900581
Change-Id: Id5617881bbf3b5f0a0b8eade5b630aa8fd65af8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758486
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687797}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1758486 branch from 26ff488 to f221d95 Aug 16, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 6a439fd into master Aug 16, 2019
13 checks passed
13 checks passed
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190816.232 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1758486 branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.