Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] Disallow refs to some non-existent files #18509

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@jugglinmike
Copy link
Contributor

jugglinmike commented Aug 16, 2019

The Chromium infrastructure generates files which it stores in a
top-level directory named "gen". In the absence of stable documentation
for how these files must be implemented, the tests which reference them
cannot be used by other implementations.

The Chromium infrastructure generates files which it stores in a
top-level directory named "gen". In the absence of stable documentation
for how these files must be implemented, the tests which reference them
cannot be used by other implementations.
@@ -350,6 +350,13 @@ class LayoutTestsRegexp(Regexp):
file_extensions = [".html", ".htm", ".js", ".xht", ".xhtml", ".svg"]
description = "eventSender/testRunner/internals used; these are LayoutTests-specific APIs (WebKit/Blink)"

class MissingDepsRegexp(Regexp):
pattern = br"[^\w]/gen/"

This comment has been minimized.

@jgraham

jgraham Aug 20, 2019 Contributor

Hmm so in theory we can probably do better than a regexp here, but it's also likely not worth it.

@jgraham jgraham merged commit 4bcd7a6 into web-platform-tests:master Aug 20, 2019
17 of 22 checks passed
17 of 22 checks passed
update-pr-preview
Details
Build Failed Build Failed
Details
Build Failed Build Failed
Details
Build Failed Build Failed
Details
Build Failed Build Failed
Details
Azure Pipelines Build #20190816.233 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (tools/ unittests: Windows Python 3) tools/ unittests: Windows Python 3 succeeded
Details
Azure Pipelines (tools/ unittests: Windows) tools/ unittests: Windows succeeded
Details
Azure Pipelines (tools/ unittests: macOS) tools/ unittests: macOS succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows) tools/wpt/ tests: Windows succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS) tools/wpt/ tests: macOS succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows) tools/wptrunner/ unittests: Windows succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS) tools/wptrunner/ unittests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - safari[experimental] Safari results
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.