Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebXR] Resolve required/optional features per the spec #18512

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 16, 2019

This adds support to resolve required/optional features against device
capabilities as well as sets up the plumbing for appropriately tailored
consent.

A WPT test for lack of device support was also added, which required
updating the tests.

Bug: 991605
Change-Id: Ibce6924492311544fd75ca36ed79aa855c943aad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757183
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689605}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1757183 branch 2 times, most recently from 3c0ce42 to 82e17c6 Aug 16, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1757183 branch from 82e17c6 to 9bd93ec Aug 19, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1757183 branch 6 times, most recently from 5c4ac43 to 9ba70a7 Aug 19, 2019
This adds support to resolve required/optional features against device
capabilities as well as sets up the plumbing for appropriately tailored
consent.

A WPT test for lack of device support was also added, which required
updating the tests.

Bug: 991605
Change-Id: Ibce6924492311544fd75ca36ed79aa855c943aad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757183
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689605}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1757183 branch from 9ba70a7 to 472f57a Aug 22, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 04c1d5a into master Aug 22, 2019
15 checks passed
15 checks passed
website-build-and-publish
Details
manifest-build-and-tag
Details
update-pr-preview
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190822.118 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1757183 branch Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.