Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Lay out flex items with ShrinkToFit in more cases #18514

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 16, 2019

A row flex box's cross size of {fit,min,max}-content isn't definite,
which affects the inline size of orthogonal children.

Bug: 845235
Change-Id: Id08a1cf6d23e9e295e87c52d426079bc7e886b74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758992
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689232}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

A row flex box's cross size of {fit,min,max}-content isn't definite,
which affects the inline size of orthogonal children.

Bug: 845235
Change-Id: Id08a1cf6d23e9e295e87c52d426079bc7e886b74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758992
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689232}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1758992 branch from 85dc479 to 3a93724 Aug 21, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit a1cec16 into master Aug 21, 2019
14 checks passed
14 checks passed
update-pr-preview
Details
Azure Pipelines Build #20190821.165 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1758992 branch Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.