Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interfaces/geolocation-API.idl #18717

Merged

Conversation

@autofoolip
Copy link
Contributor

@autofoolip autofoolip commented Aug 28, 2019

This PR was automatically created by a bot.

Before merging, please check that any tests that depend on the updated IDL files still work.

If additional changes are needed, please manually create another PR based on this one.

See the README for how the IDL files in this directory are used.


Source: https://github.com/tidoust/reffy-reports/blob/d6ebeec/whatwg/idl/geolocation-API.idl
Build: https://travis-ci.org/tidoust/reffy-reports/builds/583016313

@foolip
Copy link
Member

@foolip foolip commented Aug 28, 2019

I think it's best to wait for w3c/geolocation-api#34 to land before merging this, to not have tests requiring GeolocationPosition and GeolocationCoordinates to be exposed, when that'll soon change again.

@autofoolip autofoolip force-pushed the autofoolip:reffy-reports/geolocation-API branch from 1e02cfe to c0aae11 Sep 10, 2019
@foolip
Copy link
Member

@foolip foolip commented Sep 10, 2019

w3c/geolocation-api#34 is reflected here now.

@foolip
foolip approved these changes Sep 10, 2019
@foolip foolip merged commit cf281b7 into web-platform-tests:master Sep 10, 2019
14 checks passed
14 checks passed
update-pr-preview
Details
Azure Pipelines Build #20190910.21 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@foolip foolip deleted the autofoolip:reffy-reports/geolocation-API branch Sep 10, 2019
foolip added a commit that referenced this pull request Sep 10, 2019
Following #18717, which
added `[SecureContext]` to a few interfaces.
foolip added a commit that referenced this pull request Sep 10, 2019
Following #18717, which
added `[SecureContext]` to a few interfaces.
@foolip
Copy link
Member

@foolip foolip commented Sep 10, 2019

Right after this I was going to send a PR to rename the test, but when backing up a step to fix the commit message of bd4803e I accidentally committed directly to master in c717f05.

It's not a very review-worthy change, but I'll check for regressions on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.