Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub deployments for pr previews #18773

Closed
wants to merge 2 commits into from

Conversation

@lukebjerring
Copy link
Contributor

lukebjerring commented Aug 30, 2019

Fixes #18769

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Aug 30, 2019

@jugglinmike - I've put wpt.reviews as a placeholder here; where are mirrors currently being put?

Also, how do I test this code..?

@jugglinmike

This comment has been minimized.

Copy link
Contributor

jugglinmike commented Aug 30, 2019

Tests for the script are defined here. The script accepts the domain as input (since one might ostensiby want to run it against a GitHub Enterprise instance), and the tests use this to redirect requests to the loopback interface. In other words, you can script the client/server protocol.

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Oct 10, 2019

Closing this stale PR.

@lukebjerring lukebjerring deleted the deployments branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.