Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move forced colors tests to wpt #18907

Merged
merged 2 commits into from Sep 10, 2019
Merged

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 6, 2019

This change moves forced colors web tests to external/wpt. Having
separate reference files in wpt is not possible, so the tests are
written assuming the virtual flags are used, with the expectation
that the tests will fail in the non-virtual case.

Tests that used layout test APIs, such as testRunner and internals,
were not able to be moved to external/wpt and remain in fast/css.

Bug: 970285
Change-Id: Id7410f7d4e9f009e848807b811611051320f23ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789923
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694796}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1789923 branch from dd947b5 to dd53a97 Sep 9, 2019
This change moves forced colors web tests to external/wpt. Having
separate reference files in wpt is not possible, so the tests are
written assuming the virtual flags are used, with the expectation
that the tests will fail in the non-virtual case.

Tests that used layout test APIs, such as testRunner and internals,
were not able to be moved to external/wpt and remain in fast/css.

Bug: 970285
Change-Id: Id7410f7d4e9f009e848807b811611051320f23ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789923
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694796}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 0cb9fef into master Sep 10, 2019
13 checks passed
13 checks passed
website-build-and-publish
Details
manifest-build-and-tag
Details
update-pr-preview
Details
Azure Pipelines Build #20190910.108 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1789923 branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.