Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: counter-reset/increment inherit clears old values #18915

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 7, 2019

When we update 'counter-increment' or 'counter-reset' to 'inherit',
we now overwrite the previously resolved values, instead of
merging in the parent values.

Existing Blink fails test with
FAIL Inheritance of counter-reset replaces existing value assert_equals: expected "first 1" but got "first 1 fourth 4"
FAIL Inheritance of counter-increment replaces existing value assert_equals: expected "second 2" but got "second 2 fifth 5"

Existing Safari fails test with
FAIL Inheritance of counter-reset replaces existing value assert_equals: expected "second 0 first 1" but got "second 0 fifth 0 first 1"
FAIL Inheritance of counter-increment replaces existing value assert_equals: expected "second 2 first 0" but got "second 2 fourth 0 first 0"

Bug: 1001776
Change-Id: Ic7279a84f022f0bc156bdab1a044b3403cb2c7ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789213
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695094}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Already reviewed downstream.

When we update 'counter-increment' or 'counter-reset' to 'inherit',
we now overwrite the previously resolved values, instead of
merging in the parent values.

Existing Blink fails test with
FAIL Inheritance of counter-reset replaces existing value assert_equals: expected "first 1" but got "first 1 fourth 4"
FAIL Inheritance of counter-increment replaces existing value assert_equals: expected "second 2" but got "second 2 fifth 5"

Existing Safari fails test with
FAIL Inheritance of counter-reset replaces existing value assert_equals: expected "second 0 first 1" but got "second 0 fifth 0 first 1"
FAIL Inheritance of counter-increment replaces existing value assert_equals: expected "second 2 first 0" but got "second 2 fourth 0 first 0"

Bug: 1001776
Change-Id: Ic7279a84f022f0bc156bdab1a044b3403cb2c7ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789213
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695094}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1789213 branch from c80313f to 49951a6 Sep 10, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 73837c9 into master Sep 10, 2019
14 checks passed
14 checks passed
update-pr-preview
Details
Azure Pipelines Build #20190910.68 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1789213 branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.