Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Safari stable runs to use macOS Mojave #18927

Closed
wants to merge 1 commit into from

Conversation

@foolip
Copy link
Contributor

foolip commented Sep 9, 2019

Installing Ahem a system font no longer works on Mojave, so drop the
install step. This will probably cause a handful of regressions.

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Sep 9, 2019

@wpt-pr-bot wpt-pr-bot added the infra label Sep 9, 2019
@wpt-pr-bot wpt-pr-bot requested a review from jgraham Sep 9, 2019
Installing Ahem as a system font no longer works on Mojave, so drop
the install step. This will probably cause a handful of regressions.
@foolip foolip force-pushed the foolip/safari-stable-mojave branch from 426f5b7 to fe1196f Sep 9, 2019
@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Sep 9, 2019

This did not fail due to safaridriver, so my guess is that safardriver --enable for STP has regressed or maybe never worked on Mojave.

@burg is it a known issue with safaridriver --enable? Would getting the verbose safaridriver logs for this help debug? We can't upgrade the version of STP tested until this is resolved :/

@gsnedders

@foolip foolip added this to To do in Reliable Safari results via automation Sep 9, 2019
@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Sep 9, 2019

https://wpt.fyi/results/?diff&filter=ADC&run_id=285710001&run_id=277450003 shows the diff of two full runs. It includes some noise because of unrelated changes between 820f0f8 and 426f5b7, but the important thing is that lots of tests will be regressed because of https://bugs.webkit.org/show_bug.cgi?id=174030.

So... I think I'd suggest not upgrading Safari until STP is upgraded and not affected by that bug, or if we have to upgrade because support for High Sierra going away.

@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Sep 10, 2019

So... I think I'd suggest not upgrading Safari until STP is upgraded and not affected by that bug, or if we have to upgrade because support for High Sierra going away.

Well, we can't upgrade Safari stable until it reaches Safari stable, no, which will be even longer? Those test runs are Safari stable after all.

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Sep 10, 2019

Yeah, we should leave Safari stable on High Sierra for as long we can I think.

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Sep 11, 2019

As such, closing this. Need to take care to not upgrade stable when doing STP and all infra test jobs.

@foolip foolip closed this Sep 11, 2019
Reliable Safari results automation moved this from To do to Done Sep 11, 2019
@foolip foolip deleted the foolip/safari-stable-mojave branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.