Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Storage Access API IDL Changes #18951

Merged
merged 1 commit into from Sep 19, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 10, 2019

This change adds the initial surface area for the methods and sandbox token exposed by the Storage Access API behind the storageAccessAPI runtime flag. Initially the promises created will return simple/immediate resolutions or rejections. Future changes will update the logic of each method to ensure it is functioning correctly. Additionally Web Platform Tests have been added to validate the added behaviour.

As the newly added tests rely on running tests within iFrames an exposed bug in the content_shell testrunner JS has been fixed. The change ensures that iframes will not complete the testharness and that only the main frame will trigger completion.

Bug: 989663
Change-Id: I2388fbc25ceb95c49435aa986191b0aca925d7d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790583
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Brandon Maslen <brandm@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#697926}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1790583 branch 2 times, most recently from 568a191 to 219e8b8 Sep 10, 2019
This change adds the initial surface area for the methods and sandbox token exposed by the Storage Access API behind the storageAccessAPI runtime flag. Initially the promises created will return simple/immediate resolutions or rejections. Future changes will update the logic of each method to ensure it is functioning correctly. Additionally Web Platform Tests have been added to validate the added behaviour.

As the newly added tests rely on running tests within iFrames an exposed bug in the content_shell testrunner JS has been fixed. The change ensures that iframes will not complete the testharness and that only the main frame will trigger completion.

Bug: 989663
Change-Id: I2388fbc25ceb95c49435aa986191b0aca925d7d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790583
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Brandon Maslen <brandm@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#697926}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1790583 branch from 219e8b8 to d39f670 Sep 19, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 423c19a into master Sep 19, 2019
14 checks passed
14 checks passed
update-pr-preview
Details
Azure Pipelines Build #20190919.31 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1790583 branch Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.