Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LayoutNG] Fix vertical-align: top and bottom #18956

Merged
merged 3 commits into from Sep 12, 2019
Merged

[LayoutNG] Fix vertical-align: top and bottom #18956

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
697c4b8
[LayoutNG] Fix `vertical-align: top` and `bottom`
kojiishi Sep 10, 2019
d11d54e
Load ahem as web font and wait for fonts ready
LukeZielinski Sep 10, 2019
3e78260
Try waiting for fonts with explicit_done as well
LukeZielinski Sep 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
87 changes: 87 additions & 0 deletions css/CSS2/linebox/vertical-align-top-bottom-001.html
View file
Open in desktop
@@ -0,0 +1,87 @@
<!DOCTYPE html>
<link rel="help" href="https://drafts.csswg.org/css2/visudet.html#propdef-vertical-align" />
<link rel="author" href="mailto:kojii@chromium.org">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
<style>
section.test {
display: inline-block;
font-size: 20px;
line-height: 1.5;
font-family: Arial;
font-family: Ahem;
}
section.test > div {
background: blue;
margin-bottom: 1em;
}
.filler {
display: inline-block;
background: cyan;
height: 3em;
width: 1em;
}
.target {
display: inline-block;
background: orange;
width: 1em;
height: 1em;
}
div.top, section.top .target { vertical-align: top; }
div.text-top, section.text-top .target { vertical-align: text-top; }
div.text-bottom, section.text-bottom .target { vertical-align: text-bottom; }
div.bottom, section.bottom .target { vertical-align: bottom; }
.test .fail {
outline: red solid 5px;
}
</style>
<body>
<section class="test top">
<div><div class="filler"></div><div class="target" data-y="0"></div></div>
<div><div class="filler top"></div><div class="target" data-y="0"></div></div>
<div><div class="filler text-top"></div><div class="target" data-y="0"></div></div>
<div><div class="filler bottom"></div><div class="target" data-y="0"></div></div>
<div><div class="filler text-bottom"></div><div class="target" data-y="0"></div></div>
</section>
<section class="test text-top">
<div><div class="filler"></div><div class="target" data-y="44"></div></div>
<div><div class="filler top"></div><div class="target" data-y="5"></div></div>
<div><div class="filler text-top"></div><div class="target" data-y="5"></div></div>
<div><div class="filler bottom"></div><div class="target" data-y="35"></div></div>
<div><div class="filler text-bottom"></div><div class="target" data-y="40"></div></div>
</section>
<section class="test text-bottom">
<div><div class="filler"></div><div class="target" data-y="44"></div></div>
<div><div class="filler top"></div><div class="target" data-y="5"></div></div>
<div><div class="filler text-top"></div><div class="target" data-y="5"></div></div>
<div><div class="filler bottom"></div><div class="target" data-y="35"></div></div>
<div><div class="filler text-bottom"></div><div class="target" data-y="40"></div></div>
</section>
<section class="test bottom">
<div><div class="filler"></div><div class="target" data-y="49"></div></div>
<div><div class="filler top"></div><div class="target" data-y="40"></div></div>
<div><div class="filler text-top"></div><div class="target" data-y="45"></div></div>
<div><div class="filler bottom"></div><div class="target" data-y="40"></div></div>
<div><div class="filler text-bottom"></div><div class="target" data-y="45"></div></div>
</section>
<script>
setup({explicit_done: true});
document.fonts.ready.then(()=> {
for (let target of document.getElementsByClassName('target')) {
let container = target.parentElement;
let filler = container.firstElementChild;
let section = container.parentElement;
let pass = false;
test(() => {
let y = target.offsetTop - container.offsetTop;
assert_approx_equals(y, target.dataset.y, 0);
pass = true;
}, `${section.className.substr(5)}+${filler.className.substr(7)}`);
if (!pass)
container.classList.add('fail');
}
done();
});
</script>
</body>