Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-share] Use HTTPS URLs if possible #18964

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@saschanaz
Copy link
Contributor

saschanaz commented Sep 10, 2019

Gecko currently does not support data URIs without comma (tracked by https://bugzilla.mozilla.org/show_bug.cgi?id=1579331). Since several tests here don't have to depend on data URI support, I suggest we replace them with https://example.com to reduce failures.

Copy link
Contributor

marcoscaceres left a comment

Just noting that the data: URLs were nonconforming as they were missing a “,”... this was tripping up Gecko.

@saschanaz saschanaz merged commit ceea60d into master Sep 11, 2019
13 checks passed
13 checks passed
website-build-and-publish
Details
manifest-build-and-tag
Details
update-pr-preview
Details
Azure Pipelines Build #20190910.94 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@saschanaz saschanaz deleted the data-comma branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.