Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background-position-interpolation.html for initial/unset #18965

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 10, 2019

The initial/unset value for background-position is 0% 0%, so any
interpolation from/to that involves a calc with a percentage in it. By
the calc spec, calcs with percentages in them are not resolved when
getting the computed value - even if the percentage is 0%.

The test shouldn't pass in Chrome after this CL, but does anyway as it
resolves the expected values to not include percentages either!

See https://bugzilla.mozilla.org/show_bug.cgi?id=1574913 for where we
discovered the test was wrong.

Bug: 1002430
Change-Id: Ibacb8f9e1745f13cd2fe92894ac0f8e67e3228fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795842
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695277}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Already reviewed downstream.

The initial/unset value for background-position is 0% 0%, so any
interpolation from/to that involves a calc with a percentage in it.  By
the calc spec, calcs with percentages in them are not resolved when
getting the computed value - even if the percentage is 0%.

The test shouldn't pass in Chrome after this CL, but does anyway as it
resolves the expected values to not include percentages either!

See https://bugzilla.mozilla.org/show_bug.cgi?id=1574913 for where we
discovered the test was wrong.

Bug: 1002430
Change-Id: Ibacb8f9e1745f13cd2fe92894ac0f8e67e3228fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795842
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695277}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1795842 branch from 1366ffc to 737185d Sep 10, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 3be7186 into master Sep 10, 2019
14 checks passed
14 checks passed
update-pr-preview
Details
Azure Pipelines Build #20190910.141 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1795842 branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.