Fix background-position-interpolation.html for initial/unset #18965
Conversation
Already reviewed downstream. |
The initial/unset value for background-position is 0% 0%, so any interpolation from/to that involves a calc with a percentage in it. By the calc spec, calcs with percentages in them are not resolved when getting the computed value - even if the percentage is 0%. The test shouldn't pass in Chrome after this CL, but does anyway as it resolves the expected values to not include percentages either! See https://bugzilla.mozilla.org/show_bug.cgi?id=1574913 for where we discovered the test was wrong. Bug: 1002430 Change-Id: Ibacb8f9e1745f13cd2fe92894ac0f8e67e3228fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795842 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#695277}
1366ffc
to
737185d
3be7186
into
master
14 checks passed
14 checks passed
Azure Pipelines (affected tests without changes: Safari Technology Preview)
affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview)
affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests)
wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes)
wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The initial/unset value for background-position is 0% 0%, so any
interpolation from/to that involves a calc with a percentage in it. By
the calc spec, calcs with percentages in them are not resolved when
getting the computed value - even if the percentage is 0%.
The test shouldn't pass in Chrome after this CL, but does anyway as it
resolves the expected values to not include percentages either!
See https://bugzilla.mozilla.org/show_bug.cgi?id=1574913 for where we
discovered the test was wrong.
Bug: 1002430
Change-Id: Ibacb8f9e1745f13cd2fe92894ac0f8e67e3228fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795842
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695277}