Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18966: Upgrade various ERRORs to CRITICAL #18967

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@gsnedders
Copy link
Contributor

@gsnedders gsnedders commented Sep 10, 2019

All of these are cases where we abort the world, so they're kinda
critical I'd say.

Fixes #18966.

All of these are cases where we abort the world, so they're kinda
critical I'd say.
Copy link
Contributor

@jgraham jgraham left a comment

I could argue some of these, but I guess the principle that there should always be a critical level message if we are about to exit with status != 0 is pretty sound.

@gsnedders gsnedders merged commit 48d9218 into web-platform-tests:master Sep 10, 2019
17 of 18 checks passed
17 of 18 checks passed
update-pr-preview
Details
Azure Pipelines Build #20190910.106 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (tools/ unittests: Windows Python 3) tools/ unittests: Windows Python 3 succeeded
Details
Azure Pipelines (tools/ unittests: Windows) tools/ unittests: Windows succeeded
Details
Azure Pipelines (tools/ unittests: macOS) tools/ unittests: macOS succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows) tools/wpt/ tests: Windows succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS) tools/wpt/ tests: macOS succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows) tools/wptrunner/ unittests: Windows succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS) tools/wptrunner/ unittests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - safari[experimental] Safari results
Details
Reliable Safari results automation moved this from To do to Done Sep 10, 2019
@gsnedders gsnedders deleted the gsnedders:error-to-critical branch Sep 10, 2019
@foolip
Copy link
Member

@foolip foolip commented Sep 11, 2019

This appears to have caused both Safari (#18995) and Edge (#19005) runs to start failing.

The underlying problem was presumably already there and uncovering it is good, but this change would have benefited from triggering full runs before landing on master. That would have avoided the need to rush to fix these issues.

At this point I don't think that reverting this is necessary, but if the Safari runs are still failing it might be the best way to recover.

@gsnedders
Copy link
Contributor Author

@gsnedders gsnedders commented Sep 12, 2019

@foolip I did do a full run of STP before landing, FWIW.

@foolip
Copy link
Member

@foolip foolip commented Sep 12, 2019

Weird, it seemed like a persistent failure. Perhaps the real cause for this snuck in in between your testing and landing? Can you check git log and see if anything stands out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.