Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature-detectable API for Scroll To Text #18968

Merged
merged 1 commit into from Sep 10, 2019
Merged

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 10, 2019

Add a 'selector' member to window.location which is currently just an
empty object but can be used for feature detection for scroll to text,
and can be extended later to include properties for the fragment
directive.

Also add a test for the member to the web platform test.

Tested updated WPT locally with
run_web_tests.py --additional-driver-flag=
'--enable-blink-features=TextFragmentIdentifiers'

Bug: 1000308
Change-Id: I99b5ea14008e0b84f1e67129b7af27107b1fdec0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791793
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695182}

Add a 'selector' member to window.location which is currently just an
empty object but can be used for feature detection for scroll to text,
and can be extended later to include properties for the fragment
directive.

Also add a test for the member to the web platform test.

Tested updated WPT locally with
run_web_tests.py --additional-driver-flag=
  '--enable-blink-features=TextFragmentIdentifiers'

Bug: 1000308
Change-Id: I99b5ea14008e0b84f1e67129b7af27107b1fdec0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791793
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695182}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Already reviewed downstream.

@LukeZielinski
Copy link
Contributor

@LukeZielinski LukeZielinski commented Sep 10, 2019

Seeing flakiness on Chrome, but it appears to be existing flakiness. @Hexcles Force-merge please?

@Hexcles Hexcles merged commit 3f0fe8a into master Sep 10, 2019
13 of 14 checks passed
13 of 14 checks passed
update-pr-preview
Details
Taskcluster (pull_request) TaskGroup: failure
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
Azure Pipelines Build #20190910.113 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@Hexcles Hexcles deleted the chromium-export-b48cdedb28 branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.