Make WebXR WPT tests use viewOffset when appropriate #18973
Merged
Conversation
|
Already reviewed downstream. |
chromium-wpt-export-bot
force-pushed the
chromium-export-cl-1795492
branch
from
f57057b
to
f84e16b
Now that both position and orientation are used, some expected view matrices had to be updated. Bug: 1001733 Change-Id: I3dacd02ff724c0f173fae2c3473014df9fc6d8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795492 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#695308}
chromium-wpt-export-bot
force-pushed the
chromium-export-cl-1795492
branch
from
f84e16b
to
ed141d6
chromium-wpt-export-bot
merged commit d550f11
into
master
15 checks passed
15 checks passed
Azure Pipelines (affected tests without changes: Safari Technology Preview)
affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview)
affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests)
wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes)
wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Now that both position and orientation are used, some expected view
matrices had to be updated.
Bug: 1001733
Change-Id: I3dacd02ff724c0f173fae2c3473014df9fc6d8b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795492
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695308}