Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Fix `vertical-align: top/bottom` with leading #18974

Merged
merged 2 commits into from Sep 11, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Sep 10, 2019

This patch fixes non-culled inline boxes to take the
line-height property into account when computing top or
bottom of inline boxes in the line for vertical-align: top or bottom.

Bug: 1001418
Change-Id: Ia53b9894dd81e70e17588bc284f0df4bc4f5c382
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795535
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695443}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1795535 branch from 6e4ed20 to e21cef5 Sep 10, 2019
This patch fixes non-culled inline boxes to take the
`line-height` property into account when computing top or
bottom of inline boxes in the line for `vertical-align:
top` or `bottom`.

Bug: 1001418
Change-Id: Ia53b9894dd81e70e17588bc284f0df4bc4f5c382
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795535
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695443}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 503deee into master Sep 11, 2019
4 of 8 checks passed
4 of 8 checks passed
update-pr-preview
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs failed
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview failed
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview failed
Details
Azure Pipelines
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1795535 branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.