Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransferToImageBitmap should reset the bitmap to transparent black #18976

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Sep 10, 2019

It was implemented to reset to black, but it should be transparent
black, fixing also the broken tests that were validating the wrong
behaviour.

Bug: 1001609
Change-Id: I68e51628bd36e19b2c332da60239e6a48ebecf8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796442
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695658}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1796442 branch from 21dd590 to ba8b2f2 Sep 11, 2019
It was implemented to reset to black, but it should be transparent
black, fixing also the broken tests that were validating the wrong
behaviour.

Bug: 1001609
Change-Id: I68e51628bd36e19b2c332da60239e6a48ebecf8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796442
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695658}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1796442 branch from ba8b2f2 to 47e82d7 Sep 11, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit b272022 into master Sep 11, 2019
14 checks passed
14 checks passed
update-pr-preview
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
Azure Pipelines Build #20190911.102 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1796442 branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.