Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Don't always make a post-flexed main size definite #18980

Merged
merged 1 commit into from Sep 22, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Sep 11, 2019

It should only be definite if the element already had a definite main
size or if the container has a definite main size.

This is #2 from https://drafts.csswg.org/css-flexbox/#definite-sizes

Bug: 845235
Change-Id: I0230080d22ada93ebc8bae09aeda629d87cf5b6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797442
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698790}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1797442 branch 5 times, most recently from c1aac1e to 96fb402 Sep 12, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1797442 branch from 96fb402 to dd63721 Sep 19, 2019
It should only be definite if the element already had a definite main
size or if the container has a definite main size.

This is #2 from https://drafts.csswg.org/css-flexbox/#definite-sizes

Bug: 845235
Change-Id: I0230080d22ada93ebc8bae09aeda629d87cf5b6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797442
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698790}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1797442 branch from dd63721 to ee1e5e0 Sep 22, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit ba8a54c into master Sep 22, 2019
14 checks passed
14 checks passed
update-pr-preview
Details
Azure Pipelines Build #20190922.33 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1797442 branch Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.