Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Switch InterpolableLength implementation from length array to expression" #18981

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Sep 11, 2019

This reverts commit dd1318d7b1537af982313d51433e00fc02421225.

Reason for revert: caused performance regression crbug.com/1002177

Original change's description:

Switch InterpolableLength implementation from length array to expression

This patch changes the internal implementation of InterpolableLength
from CSSLengthArray to the following:

  • A CSSNumericLiteralValue to keep it simple when it's a simple value
  • A CSSMathExpressionNode to make it general when the underlying length
    involves calculation and math functions

In this way, we can interpolate when the length cannot be represented
as a CSSLengthArray (i.e., when comparison functions min/max are
involved).

Bug: 991672
Change-Id: Ib83fc0a07d0eb1d03a2465ac9df5282f963b935b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777025
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694443}

TBR=alancutter@chromium.org,eae@chromium.org,xiaochengh@chromium.org,futhark@chromium.org

Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 991672
Change-Id: I4467c0b4c8202dbc38ac5152620666caa38648e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797822
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695498}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

… expression"

This reverts commit dd1318d7b1537af982313d51433e00fc02421225.

Reason for revert: caused performance regression crbug.com/1002177

Original change's description:
> Switch InterpolableLength implementation from length array to expression
>
> This patch changes the internal implementation of InterpolableLength
> from CSSLengthArray to the following:
> - A CSSNumericLiteralValue to keep it simple when it's a simple value
> - A CSSMathExpressionNode to make it general when the underlying length
>   involves calculation and math functions
>
> In this way, we can interpolate when the length cannot be represented
> as a CSSLengthArray (i.e., when comparison functions min/max are
> involved).
>
> Bug: 991672
> Change-Id: Ib83fc0a07d0eb1d03a2465ac9df5282f963b935b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777025
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Reviewed-by: Alan Cutter <alancutter@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#694443}

TBR=alancutter@chromium.org,eae@chromium.org,xiaochengh@chromium.org,futhark@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 991672
Change-Id: I4467c0b4c8202dbc38ac5152620666caa38648e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797822
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695498}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1797822 branch from 8b2ae52 to d906d8c Sep 11, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit f69dc54 into master Sep 11, 2019
14 checks passed
14 checks passed
update-pr-preview
Details
Azure Pipelines Build #20190911.29 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1797822 branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.