Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert "[css-grid] Clear the override width for computing percent margins" #18988
Conversation
Already reviewed downstream. |
…gins" This reverts commit a445d168b9f54cc8902f8bac8da3bc490e441059. Reason for revert: It caused a performance regression (issue #1002700) Original change's description: > [css-grid] Clear the override width for computing percent margins > > When calculating the min-content contribution of a grid item of an auto > sized grid track we must consider the grid item's margin. When the grid > item's area is indefinite, a percent margin is resolved to zero. > However, when performing a relayout, the percent margin may be solved > against the previously computed grid area, since the grid item has > already an OverrideContainingBlockLogicalWidth value. > > In order to re-compute the percent margin properly, we need to clear > the previously override value. It's important be careful of not > clearing the override value set during intrinsic size, since we need > it for the actual layout phase. Hence, we only reset the 'override' > value when we are executing a definite strategy. > > Bug: 834643 > Change-Id: Ib936b26bee1da76afbdc886eb775746e13d40988 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782840 > Commit-Queue: Javier Fernandez <jfernandez@igalia.com> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694849} TBR=cbiesinger@chromium.org,jfernandez@igalia.com,rego@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 834643, 1002700 Change-Id: I66f2b94417be0c74dc408bc55eee3a8d44447480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796803 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#695531}
aa7a73f
to
094ce4a
364c517
into
master
12 checks passed
12 checks passed
Azure Pipelines (affected tests without changes: Safari Technology Preview)
affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview)
affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests)
wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes)
wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
chromium-wpt-export-bot commentedSep 11, 2019
•
edited
This reverts commit a445d168b9f54cc8902f8bac8da3bc490e441059.
Reason for revert: It caused a performance regression (issue #1002700)
Original change's description:
TBR=cbiesinger@chromium.org,jfernandez@igalia.com,rego@igalia.com
Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 834643, 1002700
Change-Id: I66f2b94417be0c74dc408bc55eee3a8d44447480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796803
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#695531}