Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MathML: check that determination of space-like is done from in-flow c… #18991

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@fred-wang
Copy link
Contributor

fred-wang commented Sep 11, 2019

…hildren

This is a follow-up of #18990 but for space-like elements.
It also introduces helper to navigate in-flow children and properly use
it in the space-like and embellished-op tests.
…hildren

    This is a follow-up of #18990 but for space-like elements.
    It also introduces helper to navigate in-flow children and properly use
    it in the space-like and embellished-op tests.
@fred-wang fred-wang requested a review from rwlbuis Sep 11, 2019
@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Sep 11, 2019

There are no reviewers for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

Copy link
Contributor

rwlbuis left a comment

LGTM.

@fred-wang fred-wang merged commit aa2d6a5 into master Sep 11, 2019
9 of 11 checks passed
9 of 11 checks passed
update-pr-preview
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190911.57 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
@fred-wang fred-wang deleted the space-like-in-flow branch Sep 11, 2019
@@ -0,0 +1,22 @@
function IsInFlow(element) {
var style = window.getComputedStyle(child);

This comment has been minimized.

Copy link
@fred-wang

fred-wang Sep 11, 2019

Author Contributor

this should have been element. Will fix in a follow-up commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.