Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Auto block-size shouldn't prevent child margin propagation. #18993

Merged
merged 1 commit into from Sep 13, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Sep 11, 2019

The block-end margin strut of a child can collapse with the block-end
margin strut of the parent if the computed block-size of the child is
auto. This includes unresolvable percentages (e.g. if the child has a
percentage block-size, but its containing block has auto block-size).

Update BlockLengthUnresolvable() to consider 'auto' as unresolvable.
Also include 'min-content', 'max-content', 'fit-content' and 'none'
(for max-block-size), since that seems correct, and also allows for
simplifying code at call-sites.

Bug: 1001663
Change-Id: I28decd41ca8f8340581fc68e0a4fe709d7389af8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796372
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696253}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1796372 branch 3 times, most recently from 9770223 to 45f641e Sep 12, 2019
The block-end margin strut of a child can collapse with the block-end
margin strut of the parent if the computed block-size of the child is
auto. This includes unresolvable percentages (e.g. if the child has a
percentage block-size, but its containing block has auto block-size).

Update BlockLengthUnresolvable() to consider 'auto' as unresolvable.
Also include 'min-content', 'max-content', 'fit-content' and 'none'
(for max-block-size), since that seems correct, and also allows for
simplifying code at call-sites.

Bug: 1001663
Change-Id: I28decd41ca8f8340581fc68e0a4fe709d7389af8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796372
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696253}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1796372 branch from 45f641e to e295c76 Sep 13, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 908a7ed into master Sep 13, 2019
14 checks passed
14 checks passed
update-pr-preview
Details
Azure Pipelines Build #20190913.6 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1796372 branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.