Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two css-grid tests that were broken by Ahem web font transition. #18997

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@LukeZielinski
Copy link
Contributor

LukeZielinski commented Sep 11, 2019

These tests were broken because the checkLayout method implicitly calls done() itself, which causes only the first subtest to run.

But we can call checkLayout(.., callDone=false) and call done() ourselves instead.

Copy link
Member

Hexcles left a comment

LGTM

@Hexcles Hexcles merged commit 86fb490 into web-platform-tests:master Sep 11, 2019
10 of 11 checks passed
10 of 11 checks passed
update-pr-preview
Details
Azure Pipelines Build #20190911.93 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@LukeZielinski LukeZielinski deleted the LukeZielinski:fix-css-grid-ahem branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.