Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Reland "Started implementing the STAPIT algorithm"" #18999

Closed
wants to merge 1 commit into from

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Sep 11, 2019

This reverts commit 18c5e120af5de15f5fb1af1804d6b34576b9ecd9.

Reason for revert: crbug.com/1000473

Original change's description:

Reland "Started implementing the STAPIT algorithm"

Changed SMILTimeContainer to step through all times where
an animation stops or ends when just playing it normally. Currently
it will only add slowdowns but also makes the animations more "correct".

The "repeatn-remove-add-animation.html" test has been changed to work more
reliably with the new stepping.

This commit also fixes issue 688742

Bug: 688742, 986219, 997279
Change-Id: I7f1a68c42994eb5b080a87bd2df53cb80316ecff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768765
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Edvard Thörnros <edvardt@opera.com>
Cr-Commit-Position: refs/heads/master@{#691141}

TBR=pdr@chromium.org,fs@opera.com,edvardt@opera.com

Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 688742, 986219, 997279, 1000473
Change-Id: Ic63dc9c4ed3cde92a923d27b92cf5e1c168d03d0

Reviewed-on: https://chromium-review.googlesource.com/1797464
WPT-Export-Revision: 932d86b75867a3aa92e918e35ddec9147da5a7a8

This reverts commit 18c5e120af5de15f5fb1af1804d6b34576b9ecd9.

Reason for revert: crbug.com/1000473

Original change's description:
> Reland "Started implementing the STAPIT algorithm"
>
> Changed SMILTimeContainer to step through all times where
> an animation stops or ends when just playing it normally. Currently
> it will only add slowdowns but also makes the animations more "correct".
>
> The "repeatn-remove-add-animation.html" test has been changed to work more
> reliably with the new stepping.
>
> This commit also fixes issue 688742
>
> Bug: 688742, 986219, 997279
> Change-Id: I7f1a68c42994eb5b080a87bd2df53cb80316ecff
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768765
> Reviewed-by: Fredrik Söderquist <fs@opera.com>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Commit-Queue: Edvard Thörnros <edvardt@opera.com>
> Cr-Commit-Position: refs/heads/master@{#691141}

TBR=pdr@chromium.org,fs@opera.com,edvardt@opera.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 688742, 986219, 997279, 1000473
Change-Id: Ic63dc9c4ed3cde92a923d27b92cf5e1c168d03d0
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot

This comment has been minimized.

Copy link
Collaborator Author

chromium-wpt-export-bot commented Sep 16, 2019

Close this PR because the Chromium CL has been abandoned.

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1797464 branch Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.