Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Fix incorrect rounding in ShapingLineBreaker #19002

Merged
merged 1 commit into from Sep 13, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Sep 11, 2019

This patch fixes the rounding the end position to the same
direction as the rounding the start position. Before this
change, the end position was rounded to the line-end
direction. This may have resulted in slightly larger
available space than the given one.

Although the error is slight, such an error can cause a large
visual differences because of an optimization. |NGLineBreaker|
determines the overflow by comparing the result width to the
available width, and if overflow occurs, it assumes that it
cannot break the result further when it tries to rewind.

Bug: 1002442
Change-Id: Iebee80117c9930eade029c45c561236b8916981a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797954
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696262}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1797954 branch 7 times, most recently from 6d88527 to 01935ca Sep 11, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1797954 branch from 01935ca to 2bbf6ee Sep 12, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1797954 branch from 2bbf6ee to 1a0636c Sep 12, 2019
This patch fixes the rounding the end position to the same
direction as the rounding the start position. Before this
change, the end position was rounded to the line-end
direction. This may have resulted in slightly larger
available space than the given one.

Although the error is slight, such an error can cause a large
visual differences because of an optimization. |NGLineBreaker|
determines the overflow by comparing the result width to the
available width, and if overflow occurs, it assumes that it
cannot break the result further when it tries to rewind.

Bug: 1002442
Change-Id: Iebee80117c9930eade029c45c561236b8916981a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797954
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696262}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1797954 branch from 1a0636c to d2ec186 Sep 13, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 8893b1b into master Sep 13, 2019
12 checks passed
12 checks passed
update-pr-preview
Details
Azure Pipelines Build #20190913.11 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1797954 branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.