Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Fix what replaced elements resolve their block-size against. #19006

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Sep 11, 2019

Previously if we had a table-cell which was %-block-size based,
replaced elements would resolve their percentages against this height
during both the "measure" and "layout" phases.

This was incorrect, instead during the measure phase we should only
resolve a percentage against a "fixed" height table-cell, and indefinite
for all other cases.

Bug: 1001083
Change-Id: If4217a7545830d1279911753930bf821c2c023d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793942
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695809}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1793942 branch 2 times, most recently from 93d78ed to a18b759 Sep 11, 2019
Previously if we had a table-cell which was %-block-size based,
replaced elements would resolve their percentages against this height
during both the "measure" and "layout" phases.

This was incorrect, instead during the measure phase we should only
resolve a percentage against a "fixed" height table-cell, and indefinite
for all other cases.

Bug: 1001083
Change-Id: If4217a7545830d1279911753930bf821c2c023d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793942
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695809}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1793942 branch from a18b759 to 2505fef Sep 11, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit dcae3ce into master Sep 11, 2019
14 checks passed
14 checks passed
update-pr-preview
Details
Azure Pipelines Build #20190911.160 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1793942 branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.