Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webxr-test to support FakeXRFieldOfViewInit #19014

Merged
merged 1 commit into from Sep 13, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Sep 11, 2019

In order to enable tests of the render depth, without requiring the test
implementations to perform this decomposition, the webxr-test-api was
updated to allow a fieldOfView parameter to be provided, which would
override any passed in projectionMatrix

Bug: 1003135
Change-Id: I54fce9832b72a36cf99130f626afc0c1c227e943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799318
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696210}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1799318 branch from 11e2955 to 516705f Sep 12, 2019
In order to enable tests of the render depth, without requiring the test
implementations to perform this decomposition, the webxr-test-api was
updated to allow a fieldOfView parameter to be provided, which would
override any passed in projectionMatrix

Bug: 1003135
Change-Id: I54fce9832b72a36cf99130f626afc0c1c227e943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799318
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696210}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1799318 branch from 516705f to 057b7c0 Sep 12, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 0bbb480 into master Sep 13, 2019
15 checks passed
15 checks passed
update-pr-preview
Details
Azure Pipelines Build #20190912.163 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1799318 branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.