Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding resource timing test that checks for #hash in the URL #19015

Merged
merged 3 commits into from Sep 29, 2019

Conversation

@stoyan
Copy link
Contributor

stoyan commented Sep 11, 2019

Mostly copypasta of the resource-timing/resource_cached.htm test

Currently the test fails in Safari. Safari seems to strip the hash when it comes to images. XHRs look ok.

Mostly copypasta of the `resource-timing/resource_cached.htm` test

Currently the test fails in Safari. Safari seems to strip the hash when it comes to images. XHRs look ok.
@yoavweiss

This comment has been minimized.

Copy link
Contributor

yoavweiss commented Sep 12, 2019

Thank you for flying WPT! :D

I suspect you don't really need the whole iframe setup here, and could easily test the same thing by going to hash_responses.html directly, and running the asserts there.

using relatively recent features (filter and const), not sure if it's ok
Copy link
Contributor

yoavweiss left a comment

LGTM!!

@yoavweiss

This comment has been minimized.

Copy link
Contributor

yoavweiss commented Sep 13, 2019

The lint bot doesn't like you patch for some reason. Can you run ./wpt lint and see why?

./wpt lint resource-timing
@yoavweiss yoavweiss merged commit 68abc3a into web-platform-tests:master Sep 29, 2019
11 checks passed
11 checks passed
update-pr-preview
Details
Azure Pipelines Build #20190913.83 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.