Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SystemWebViewShell's use of is_alive property. #19166

Merged
merged 2 commits into from Oct 11, 2019

Conversation

@cmumford
Copy link
Contributor

cmumford commented Sep 19, 2019

SystemWebViewShell.is_alive() was referencing the
ChromeDriverServer.is_alive property (inherited from WebDriverServer),
but calling it as if it were a function. Encountered this when
running wpt run --debugger ...

SystemWebViewShell.is_alive() was referencing the
ChromeDriverServer.is_alive property (inherited from WebDriverServer),
but calling it as if it were a function. Encountered this when
running `wpt run --debugger ...`
Copy link
Contributor

gsnedders left a comment

Grepping it through it, it appears like we get this wrong in essentially every browser. I think just doing this line-for-line replacement throughout the directory is all that's needed. Could you fix this elsewhere too?

@cmumford

This comment has been minimized.

Copy link
Contributor Author

cmumford commented Oct 4, 2019

Good point @gsnedders - fixed for all browsers.

@cmumford

This comment has been minimized.

Copy link
Contributor Author

cmumford commented Oct 10, 2019

ping. Is this blocked on me?

@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Oct 11, 2019

No, blocked on me attending/speaking at a conference and nobody else responding. 🙂

@gsnedders gsnedders merged commit 8be26a0 into web-platform-tests:master Oct 11, 2019
17 checks passed
17 checks passed
website-build-and-publish
Details
Azure Pipelines Build #20191004.126 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (tools/ unittests: Windows Python 3) tools/ unittests: Windows Python 3 succeeded
Details
Azure Pipelines (tools/ unittests: Windows) tools/ unittests: Windows succeeded
Details
Azure Pipelines (tools/ unittests: macOS) tools/ unittests: macOS succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows) tools/wpt/ tests: Windows succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS) tools/wpt/ tests: macOS succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows) tools/wptrunner/ unittests: Windows succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS) tools/wptrunner/ unittests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - safari[experimental] Safari results
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.