Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docs when touching docs/ and select directories in PRs #19303

Merged
merged 2 commits into from Oct 2, 2019

Conversation

@foolip
Copy link
Contributor

foolip commented Sep 25, 2019

No description provided.

@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Sep 25, 2019

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@foolip foolip requested a review from jugglinmike Sep 25, 2019
@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Sep 25, 2019

The docs building is broken on master now and we should catch it somehow. I used the path filtering to avoid showing it on all PRs, since the list of checks is already quite noisy.

@jugglinmike

This comment has been minimized.

Copy link
Contributor

jugglinmike commented Oct 1, 2019

We're currently generating some documentation from files outside of docs/ (and we plan to do still more), so it's possible that a pull request that doesn't touch docs/ could still break the build.

I'm happy to merge this as-is since some visibility is better than no visibility, but I wanted to make sure you were aware of that, first.

@wpt-pr-bot wpt-pr-bot requested a review from jgraham Oct 1, 2019
@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Oct 1, 2019

Would also depending on tools/ and resources/ be enough right now? As long as the job doesn't trigger on most PRs that just update some tests I think it's fine if it over-triggers in directories that are mostly touched by core maintainers.

@jugglinmike

This comment has been minimized.

Copy link
Contributor

jugglinmike commented Oct 1, 2019

Yeah, that sounds good to me!

@foolip foolip changed the title Build docs when modifying docs/ in PRs Build docs when touching docs/ and select directories in PRs Oct 2, 2019
@jugglinmike jugglinmike merged commit 052f1b2 into master Oct 2, 2019
13 checks passed
13 checks passed
Azure Pipelines Build #20191002.115 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@jugglinmike jugglinmike mentioned this pull request Oct 2, 2019
@foolip foolip deleted the foolip/build-docs-prs branch Oct 2, 2019
@zcorpan zcorpan added GitHub Actions and removed .github labels Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.