Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI when changing input's value with setAttribute #19498

Merged
merged 1 commit into from Oct 10, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Oct 3, 2019

This patch fixes a bug where setting a range input element's default
value with setAttribute('value', defaultValue) does not update the UI of
the range input to show the new default value.
The bug is present in WebKit, but not present in Firefox.

Bug: 852938
Change-Id: Ibef8c0c6cefeb221a0d9220a966b04a03d815c76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834647
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704667}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1834647 branch 3 times, most recently from d47aa84 to ec9b923 Oct 8, 2019
This patch fixes a bug where setting a range input element's default
value with setAttribute('value', defaultValue) does not update the UI of
the range input to show the new default value.
The bug is present in WebKit, but not present in Firefox.

Bug: 852938
Change-Id: Ibef8c0c6cefeb221a0d9220a966b04a03d815c76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834647
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704667}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1834647 branch from ec9b923 to 91ef342 Oct 10, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit a879756 into master Oct 10, 2019
13 checks passed
13 checks passed
Azure Pipelines Build #20191010.114 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1834647 branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.